Patch for scrolling the tabctrl correctly

Discuss development issues and submit patches here
Post Reply
ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Patch for scrolling the tabctrl correctly

Post by ajs »

Patch for scrolling the tabctrl correctly

The range of the tabctrl was not updated correctly when creating/deleting tabs, so scrolling of the tabctrl was not 100% possible. Also closing all visible tabs was causing problems (empty tab control even though hidden tab existed).

Patch against commit 195
Attachments
patch_54__v195.zip
(1.27 KiB) Downloaded 528 times
David Erceg
Site Admin
Posts: 933
Joined: Sat Apr 18, 2009 1:46 am

Re: Patch for scrolling the tabctrl correctly

Post by David Erceg »

What precisely is the bug here? I'm also not sure what you mean by closing all visible tabs (the tab control is never empty)?

Also, unless there's a bug in Windows, I don't see why the tab control itself wouldn't be able to update it's own range?
ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Patch for scrolling the tabctrl correctly

Post by ajs »

I will explain with an example using the last nightly built version.

BUG 1
1) open E++, let's imagine it has a single tab open at the beginning. Create 2 or more tabs. Now try to scroll the tabs on the tab control using the mouse wheel when the mouse cursor is over the tab control. You should see that scrolling is not working.

2) now close and reopen E++ and try to scroll again. You should see that scrolling the tabs is now possible.

BUG 2
1) open E++ and creates a few tabs. close and reopen E++ as explained above, so that scrolling is possible.

2) select any tab but the last one and then scroll the tabs with the mouse wheel so that only the last tab is visible
Capture_09-03-2011-16.19.13.gif
Capture_09-03-2011-16.19.13.gif (1.88 KiB) Viewed 6413 times
Capture_09-03-2011-16.19.22.gif
Capture_09-03-2011-16.19.22.gif (1.56 KiB) Viewed 6413 times
3) right-click on the tab and close the last tab (which was not selected, it is the key). The tab control displays no tabs, even though the other tabs are still there (and the listview is actually displaying the contents of the selected-but-hidden tab)
Capture_09-03-2011-16.19.34.gif
Capture_09-03-2011-16.19.34.gif (1.33 KiB) Viewed 6413 times
I hope this is more clear. The patch fixes these problems
Post Reply