Pane right click hangs and crashes [solved]

[ajs]

Hi twinsen,
I wonder if the problem you have has something to do with your computer/Win XP.
I tried jsut now E++ on a Windows XP 32 bit running on a virtual machine and I didn't have any problem with the right-click menu. I tried several files and folders, no issue.
Also on my win 7 64bit I have no problem.

If I understand correctly, your pcmi pointer is not set correctly by
pcmi = (CustomMenuInfo_t *)mi.dwItemData;
since it would cause a crash if you didn't check for
if(pcmi &&

So I think the problem comes from somewhere else. For example is the MENUITEMINFO mi initialized corretly by the call to GetMenuItemInfo((HMENU)pDrawItem->hwndItem,pDrawItem->itemID,FALSE,&mi) ?

As I said, I can't reproduce the problem on my computer....

[twinsen]

Thanks for testing xp.
I tested the nightly 32bit exe on a different pc and the right click crashes.
This pc does not have "tortoise git", but it has a bunch of others.
I will try a clean XP in a virtualbox to see if it works, then install each context extension and see what it has trouble with. Its great to know it might work on a clean pc!

This pc has on the background click of windows explorer:
TortoiseCVS (CVS menu with a turtle icon)
So hopefully that is the problem... I should be able to uninstall that as I don't have any cvs codebases left.

For a folder it has:
winamp
some custom ones (cmd prompt, creating m3u, custom building code)*
PowerCmd*
7zip*
Beyond Compare 3*
Convert to file format... (seems to be some .dds texture creator)
Magic ISO*
TortoiseCVS*
TortoiseSVN*
WinZip*
Creat ISO Image File...
Malware Bytes*
Unlocker*
Burn4Free*
And of course Explorer++

files:
Ones marked * above
010 Editor v3
Notepad++
vim (gvim)
some custom ones (wordpad, metapad, png conversion)

The files and folders context menus shouldn't be a problem, but its possible something stores junk in the background registry key.

[ajs]

on my Win 7 machine I have got almost the same entries in the R-click menu , with a few exceptions.
The Win XP I tried is the one which comes from Microsoft to run Win 32 applications within Win 7 (see WOW on microsoft website) and doesn't have much new entries in the R-click menu.
On another XP from a different virtual machine (this XP was originally running on my previous computer and I ported to the virtual machine) I downloaded and tried the last 32 bit nightly built, and yet no problem. This XP has got a lot of stuff installed as well.
So I would say the problem must be caused by a program you installed on your computer.
As you said, try on a clean system and then try to add programs one by one.

[twinsen]

I tried on a fairly clean Windows XP SP2 with no background context menu entries.
The "new" menu looked empty, but clicking on the first two empty boxes did create a new directory and shortcut. None of the other empty boxes did anything. And the view menu is a placeholder.

RightClickCleanerXP.png (2.46 KiB) Viewed 13720 times

[albher]

With the latest nightly build (14.Jan.2010) i get exactly the same problem as shown above ("new menu" looks empty). Version 1.2 shows correctly the list of available items.

System: WindowsXP 32 bit, SP3, fully updated, Portuguese language.

PS: Did not click on the empty items of the "list"

[ajs]

Hi Albher,
Twinsen actually found out that some of the changes made after v1.2 (with commit 145 to be correct) broke both the View and the New menu.
I have prepared a patch to fix the problem with the "view menu", but it hasn't been committed yet, so as soon as David commits the patch, the nightly build should be ok.
For the "new" menu I have no problem on my computer so I can not reproduce that. Twinsen is working on that to try to find the problem and fix it.

[twinsen]

Implemented:
* New menu which works in Windows XP (uses m_pShellContext3->HandleMenuMsg2)
* Icons
* View menu
* Help for each entry is displayed in the status bar
* A few status bar bugs fixed (members were not set properly)
Note: Background context menu extensions are currently removed.

Demo Exe: http://members.iinet.net.au/~bertdb/rya ... htClick.7z
(tested on both XP and Win7 32bit)

TODO:
Implement background context menu extensions for XP.
Eg for TortoiseSVN you should have "SVN Checkout..." and "TortoiseSVN" with icons above the new menu.
Make CContextMenuManager::AddMenuEntries have same result as OnListViewBackgroundRClick, and use it instead.
Finish InitializeRightClickMenu - it has commented code and TODOs.

For the view menu see also:
http://www.explorerplusplus.com/phpBB3/ ... 613&p=1718

Code:

FixWinXPBackgroundRightClick_R163_patch.7z

(4.63 KiB) Downloaded 703 times

[laurelindorien]

FYI. I was also having the crash on clicking in empty area. The demo exe has fixed the issue.

[David Erceg]

FYI. I was also having the crash on clicking in empty area. The demo exe has fixed the issue.

Which build was crashing? v1.2, or one of the more recent nightly builds?

[twinsen]

I just downloaded the latest nightly 32bit exe and it still crashes on my XP computer (same with 1.3 beta).
The bug that was introduced in Revision 145 is still present and makes Explorer++ unusable.
Version 1.2 does not have the crash.

The patch for Revision 163 that fixes this bug is in this thread.
If you come up with an alternate strategy to fix the crash I can test to see if the crash has gone.
I would like this crash fixed in 1.3.